1 files changed, 15 insertions, 25 deletions

diff --git a/rsync/trace.h b/rsync/trace.h
index 60a6477..2bb8552 100644
--- a/rsync/trace.h
+++ b/rsync/trace.h
@@ -31,44 +31,37 @@
 /*
  * trace may be turned off.
  *
  * error is always on, but you can return and continue in some way
  *
  * fatal terminates the whole process
  */
 
-void rs_fatal0(char const *s, ...);
-void rs_error0(char const *s, ...);
-void rs_trace0(char const *s, ...);
-
-void rs_log0_nofn(int level, char const *fmt, ...);
-
-#ifdef __GNUC__
+#if defined(HAVE_VARARG_MACROS) && defined(__GNUC__)
+/*
+ * TODO: Don't assume this is a gcc thing; rather test in autoconf for
+ * support for __FUNCTION__.  One simple way might just be to try compiling 
+ * the definition of one of these functions!
+ *
+ * TODO: Also look for the C9X predefined identifier `_function', or
+ * whatever it's called.
+ */
 
 void rs_log0(int level, char const *fn, char const *fmt, ...)
     __attribute__ ((format(printf, 3, 4)));
 
 #ifdef DO_RS_TRACE
 #  define rs_trace(fmt, arg...)                            \
     do { rs_log0(RS_LOG_DEBUG, __FUNCTION__, fmt , ##arg);  \
     } while (0)
 #else
-#  define rs_trace(s, str...)
+#  define rs_trace(fmt, arg...)
         #endif/* !DO_RS_TRACE */
 
-/*
- * TODO: Don't assume this is a gcc thing; rather test in autoconf for
- * support for __FUNCTION__ and varargs macros.  One simple way might
- * just be to try compiling the definition of one of these functions!
- *
- * TODO: Also look for the C9X predefined identifier `_function', or
- * whatever it's called.
- */
-
 #define rs_log(l, s, str...) do {              \
      rs_log0((l), __FUNCTION__, (s) , ##str);  \
      } while (0)
 
 
 #define rs_error(s, str...) do {                       \
      rs_log0(RS_LOG_ERR,  __FUNCTION__, (s) , ##str);  \
      } while (0)
@@ -77,40 +70,37 @@ void rs_log0(int level, char const *fn, char const *fmt, ...)
 #define rs_fatal(s, str...) do {               \
      rs_log0(RS_LOG_CRIT,  __FUNCTION__,       \
               (s) , ##str);                    \
      abort();                                  \
      } while (0)
 
 
 #else /************************* ! __GNUC__ */
-
+#  define rs_trace rs_trace0
 #  define rs_fatal rs_fatal0
 #  define rs_error rs_error0
 #  define rs_log   rs_log0_nofn
-
-#  ifdef DO_RS_TRACE
-#    define rs_trace rs_trace0
-        #  endif                /* DO_RS_TRACE */
         #endif                  /* ! __GNUC__ */
 
-
+void rs_trace0(char const *s, ...);
+void rs_fatal0(char const *s, ...);
+void rs_error0(char const *s, ...);
 void rs_log0(int level, char const *fn, char const *fmt, ...);
-
+void rs_log0_nofn(int level, char const *fmt, ...);
 
 enum {
     RS_LOG_PRIMASK       = 7,   /**< Mask to extract priority
                                    part. \internal */
 
     RS_LOG_NONAME        = 8    /**< \b Don't show function name in
                                    message. */
 };
 
 
-
 /**
  * \macro rs_trace_enabled()
  *
  * Call this before putting too much effort into generating trace
  * messages.
  */
 
 extern int rs_trace_level;