Age | Commit message (Collapse) | Author | Files | Lines |
---|---|---|---|---|
2007-01-29 | Each file in this commit exhibits a problem where a variable is made in | erik | 2 | -6/+2 |
some way but never used. This is a tricky problem with Qt since almost all UI forms are made but not used (like QLabel). But I am pretty confident that these changes are correct and do not have any aspect of a change to the UI. In most cases, there are just variables that are made and then copied over (like in iteration over lists or assignment of pointers based on conditionals). | ||||
2007-01-29 | Each file in this commit has an issue where the initial value of a variable | erik | 10 | -46/+50 |
is assumed to be something but no initial value is given. This commit changes that by either assigning an initial value or removing the assumption on an initial value (usually the former). | ||||
2007-01-29 | Strictly removal of cruft (commented out old code). | erik | 1 | -22/+0 |
2007-01-26 | Both files in this commit exhibit the wrong way to use temporary files. | erik | 1 | -3/+24 |
For TEHistory.cpp, it uses tmpfile() which produces a file which has a name that can be guessed. For vmemo.cpp, it uses tmpname() which only creates a predictable string. Both uses have been switched to using mkstemp() wrapped around umask(). This produces a much less predictable file that also has guaranteed restrictive permissions. I went a little farther in vmemo because it calls out to the shell using system to 'mv' the new file. That is kinda wasteful so I switched it to use rename instead. | ||||
2007-01-26 | The Expand call does not check for null termination of the URL strings | erik | 1 | -2/+4 |
that it is expanding. Since strlen() is used with the URLs after Expand is used, it is good idea to make sure that Expand terminates the strings. This commit changes that so that the URL strings are guaranteed to be terminated after expansion. | ||||
2007-01-26 | A couple of places where a string is overrun. This fixes both of them. | erik | 1 | -2/+3 |
2007-01-26 | Each file in this commit exhibit an example of what prevent calls | erik | 1 | -1/+1 |
'reverse inull'. All that means is that a pointer gets dereferenced. Then a pointer gets checked for validity before being dereferenced again. This almost always points to shenanigans. For example, the konsole.cpp file has this konsoleInit() call which passes in a const char** shell variable. Since it is a double pointer the programmer who wrote the code made the mistake of mixing the checking of the pointer and the pointer that points to the pointer. This commit attempts to correct that. Of course there are other instances of the same thing. But they all boil down to a small mistake which might have produced strange side effects. | ||||
2007-01-24 | There was quite a bit of deadwood in this file. I am removing it to make | erik | 1 | -65/+0 |
the file more readable (and smaller overall). | ||||
2007-01-24 | Each file in this commit has an instance where a pointer is checked at | erik | 3 | -66/+69 |
one point in the code and then not checked in another point in the code. If it needed to be checked once, it needs to be checked the other time. If not the application could segfault. | ||||
2007-01-24 | Eac one the files in this commit had an instance where a code path is | erik | 1 | -7/+0 |
never traversed because of conditionals operating on values that never change. | ||||
2007-01-24 | Every file in this commit has a memory leak of some kind or another. I think | erik | 3 | -29/+33 |
all of them are minor and should not effect properly running code. But if I were you I would give libstocks and the stockticker plugin in Today a wide berth. That library is atrocious. | ||||
2007-01-22 | Every file in this commit makes a call to a function which returns a value. | erik | 7 | -55/+56 |
Each file also didn't check the return value. This commit changes it so that every single non-checked call in these files is checked. | ||||
2007-01-19 | core/opie-login/loginwindowimpl.cpp has a fix to properly free strings | erik | 1 | -0/+1 |
that were dup'ed. noncore/apps/opie-reader/Bkmks.cpp deletes a temporary pointer that was not being properly disposed of. | ||||
2007-01-19 | Every file in this commit has a change to check the return value of a call. | erik | 2 | -3/+7 |
2007-01-19 | Every single file in this commit had a memory leak where a resource is | erik | 7 | -16/+38 |
allocated in the constructor but not de-allocated in the destructor. This commit fixes that. | ||||
2007-01-13 | Prompt user to save on closing a modified file; prompt user on Save As if ↵ | paule | 2 | -25/+116 |
specified file already exists; change tab to show filename when saving a new file | ||||
2007-01-13 | Improve layout of Highlight Modes tab so that it fits on QVGA screens, ↵ | paule | 1 | -29/+25 |
allowing the OK/Cancel buttons on the dialog to be shown. Fixes bug #1373. | ||||
2007-01-13 | Clear document modified flag on save | paule | 1 | -1/+6 |
2007-01-13 | Delete configuration dialog object on closing | paule | 1 | -1/+2 |
2007-01-13 | Add Edit menu with find, replace & go to line functions. Uses dialogs/code ↵ | paule | 2 | -8/+23 |
already provided by libkate. Fixes bug #1231. | ||||
2007-01-13 | Set sensible minimum width for Goto Line dialog | paule | 1 | -0/+3 |
2007-01-13 | Call qApp->processEvents() before deleting dialog objects to avoid crashes ↵ | paule | 1 | -0/+3 |
(Qt bug?) | ||||
2007-01-10 | All of the files included have instances where an array is new'ed but | erik | 4 | -6/+6 |
the corresponding delete does not have the corresponding [] argument. | ||||
2007-01-10 | BUG: The case statement was using err to figure out what to say about | erik | 1 | -1/+1 |
why sendfile didn't work. Since err is only the return value of sendfile this meant that it never reported the right thing because it can only be -1 at this point. What the author probably wanted to do was look at errno since that is what the man page says will have the real error info. FIX: Switch the case statement to use errno. | ||||
2006-12-30 | Fix for bug# 0001553 Submited by Paul Eggleton | korovkin | 3 | -27/+506 |
avancedfm uses FileInfoDialog and QFileInfo to display the selected file information. | ||||
2006-05-25 | g++ 4.1.1 fix | mickeyl | 2 | -2/+2 |
2006-01-17 | Opie-console fallback to FixedFont settings from qpe.conf in config | hrw | 1 | -1/+4 |
2005-10-18 | fixed bug #1647 - Opie-console doesn't respect scroll-bar on left side | hrw | 1 | -10/+15 |
2005-10-12 | fixed bug #1686: opie-console lack U I setting for switching scrollbar | hrw | 4 | -0/+54 |
2005-08-31 | Fix support for non-English language texts | drw | 5 | -7/+11 |
2005-08-25 | fix search results | llornkcor | 1 | -12/+13 |
2005-08-24 | optimize search. fix other things | llornkcor | 3 | -200/+170 |
2005-08-23 | fix url | llornkcor | 2 | -2/+2 |
2005-08-11 | add opie-smb | llornkcor | 2 | -13/+32 |
2005-08-09 | Several updates to Dagger, see /noncore/apps/dagger/ChangeLog for more ↵ | drw | 6 | -44/+51 |
information | ||||
2005-08-09 | left align toolbar icons | llornkcor | 1 | -12/+15 |
2005-08-04 | fix # 0001687: opening desktop file | llornkcor | 1 | -2/+3 |
2005-07-19 | removed hardcoded font size from graphs - now it's 1 smaller then default one | hrw | 1 | -2/+4 |
it would be nice to get _pCfg->getUseSmallFont here like it is done for lists | ||||
2005-06-24 | s,cardmon/pcmcia,pcmcia, | mickeyl | 1 | -1/+1 |
2005-06-16 | 8 and 16 bit flite plugins need to have different names | pohly | 1 | -1/+1 |
2005-06-15 | Forgot to remove include | drw | 1 | -1/+0 |
2005-06-11 | - read default profile fixed font specs from qpe.conf, if profile doesn't exist | mickeyl | 1 | -3/+17 |
- fix initial background color | ||||
2005-06-03 | Add config option to use smaller font for checkbook transaction tab - patch ↵ | drw | 5 | -22/+38 |
courtesy of hrw | ||||
2005-05-17 | Resource -> OResource | drw | 1 | -37/+30 |
2005-05-17 | Resource -> OResource | drw | 1 | -17/+19 |
2005-05-17 | Resource -> OResource | drw | 3 | -5/+6 |
2005-05-17 | Resource -> OResource | drw | 2 | -19/+33 |
2005-05-17 | gcc4 compile fix | mickeyl | 1 | -1/+1 |
2005-05-16 | Resource -> OResource | drw | 2 | -30/+26 |
2005-05-16 | Resource -> OResource | drw | 3 | -26/+30 |