From 17a29825dcf56cb0e224848e71e24ee6a884890b Mon Sep 17 00:00:00 2001
From: benmeyer <benmeyer>
Date: Mon, 04 Nov 2002 15:17:58 +0000
Subject: Fix bug and gives more user feedback now

---
(limited to 'noncore')

diff --git a/noncore/net/networksetup/interfaces/interface.cpp b/noncore/net/networksetup/interfaces/interface.cpp
index 929b3a1..e4f405e 100644
--- a/noncore/net/networksetup/interfaces/interface.cpp
+++ b/noncore/net/networksetup/interfaces/interface.cpp
@@ -63,16 +63,21 @@ void Interface::setModuleOwner(Module *owner){
  */ 
 void Interface::start(){
   // check to see if we are already running.	
-  if(true == status)
+  if(true == status){
+    emit (updateMessage("Unable to start interface,\n already started"));
     return;
-
+  }
+  
   int ret = system(QString("%1 %2 up").arg(IFCONFIG).arg(this->name()).latin1());
   // See if it was successfull...
-  if(ret != 0)
+  if(ret != 0){
+    emit (updateMessage("Starting interface failed."));
     return;
-  
+  }
+
   status = true;
   refresh();
+  emit (updateMessage("Start successfull"));
 }
 
 /**
@@ -80,15 +85,20 @@ void Interface::start(){
  */
 void Interface::stop(){
   // check to see if we are already stopped.	
-  if(false == status)
+  if(false == status){
+    emit (updateMessage("Unable to stop interface,\n already stopped"));
     return;
+  }
 	  
   int ret = system(QString("%1 %2 down").arg(IFCONFIG).arg(this->name()).latin1());
-  if(ret != 0)
+  if(ret != 0){
+    emit (updateMessage("Stopping interface failed."));
     return;
+  }
 
-  status = true;
+  status = false;
   refresh();
+  emit (updateMessage("Stop successfull"));
 }
 
 /**
diff --git a/noncore/net/networksetup/interfaces/interface.h b/noncore/net/networksetup/interfaces/interface.h
index dc9c6d3..fc064fe 100644
--- a/noncore/net/networksetup/interfaces/interface.h
+++ b/noncore/net/networksetup/interfaces/interface.h
@@ -11,7 +11,8 @@ class Interface : public QObject{
 
 signals:
   void updateInterface(Interface *i);
-	
+  void updateMessage(const QString &message);
+  
 public:
   Interface(QObject * parent=0, const char * name= "unknown", bool status = false);
   virtual ~Interface(){};
diff --git a/noncore/net/networksetup/interfaces/interfaceinformationimp.cpp b/noncore/net/networksetup/interfaces/interfaceinformationimp.cpp
index 43483fb..39575c4 100644
--- a/noncore/net/networksetup/interfaces/interfaceinformationimp.cpp
+++ b/noncore/net/networksetup/interfaces/interfaceinformationimp.cpp
@@ -4,6 +4,8 @@
 #include <qpushbutton.h>
 #include <qlabel.h>
 #include <qgroupbox.h>
+#include <qmessagebox.h>
+
 #include <assert.h>
 
 /**
@@ -15,13 +17,13 @@ InterfaceInformationImp::InterfaceInformationImp(QWidget *parent, const char *na
   
   interface = i;
   connect(i, SIGNAL(updateInterface(Interface *)), this, SLOT(updateInterface(Interface *)));
+  connect(i, SIGNAL(updateMessage(const QString &)), this, SLOT(showMessage(const QString &)));
   updateInterface(interface);
   connect(startButton, SIGNAL(clicked()), interface, SLOT(start()));
   connect(stopButton, SIGNAL(clicked()), interface, SLOT(stop()));
   connect(restartButton, SIGNAL(clicked()), interface, SLOT(restart()));
   connect(refreshButton, SIGNAL(clicked()), interface, SLOT(refresh()));
   connect(advancedButton, SIGNAL(clicked()), this, SLOT(advanced()));
-  
 }
 
 /**
@@ -66,5 +68,14 @@ void InterfaceInformationImp::advanced(){
   a->show();
 }
 
+/**
+ * Messages from the interface if start/stop went as planned.
+ * Purly for user feedback.
+ * @param message the message to display.
+ */ 
+void InterfaceInformationImp::showMessage(const QString &message){
+  QMessageBox::information(this, "Message", message, QMessageBox::Ok);
+}
+
 // infoimp.cpp
 
diff --git a/noncore/net/networksetup/interfaces/interfaceinformationimp.h b/noncore/net/networksetup/interfaces/interfaceinformationimp.h
index 42213cc..65cdfe0 100644
--- a/noncore/net/networksetup/interfaces/interfaceinformationimp.h
+++ b/noncore/net/networksetup/interfaces/interfaceinformationimp.h
@@ -15,6 +15,7 @@ public:
 private slots:
   void advanced();
   void updateInterface(Interface *i);
+  void showMessage(const QString &message);
 
 private:
   Interface *interface;
diff --git a/noncore/net/networksetup/interfaces/interfaces.pro b/noncore/net/networksetup/interfaces/interfaces.pro
index 9a024f6..d6b43fb 100644
--- a/noncore/net/networksetup/interfaces/interfaces.pro
+++ b/noncore/net/networksetup/interfaces/interfaces.pro
@@ -1,7 +1,7 @@
 TEMPLATE        = lib
 CONFIG          += qt warn_on release
 #CONFIG		+= qt warn_on debug
-DESTDIR		= $(QTDIR)/lib$(PROJMAK)
+#DESTDIR		= $(QTDIR)/lib$(PROJMAK)
 HEADERS		= interface.h  interfaceinformationimp.h  interfaces.h  interfacesetupimp.h
 SOURCES		= interface.cpp interfaces.cpp interfaceinformationimp.cpp  interfacesetupimp.cpp
 INCLUDEPATH	+= $(OPIEDIR)/include ../
diff --git a/noncore/settings/networksettings/interfaces/interface.cpp b/noncore/settings/networksettings/interfaces/interface.cpp
index 929b3a1..e4f405e 100644
--- a/noncore/settings/networksettings/interfaces/interface.cpp
+++ b/noncore/settings/networksettings/interfaces/interface.cpp
@@ -63,16 +63,21 @@ void Interface::setModuleOwner(Module *owner){
  */ 
 void Interface::start(){
   // check to see if we are already running.	
-  if(true == status)
+  if(true == status){
+    emit (updateMessage("Unable to start interface,\n already started"));
     return;
-
+  }
+  
   int ret = system(QString("%1 %2 up").arg(IFCONFIG).arg(this->name()).latin1());
   // See if it was successfull...
-  if(ret != 0)
+  if(ret != 0){
+    emit (updateMessage("Starting interface failed."));
     return;
-  
+  }
+
   status = true;
   refresh();
+  emit (updateMessage("Start successfull"));
 }
 
 /**
@@ -80,15 +85,20 @@ void Interface::start(){
  */
 void Interface::stop(){
   // check to see if we are already stopped.	
-  if(false == status)
+  if(false == status){
+    emit (updateMessage("Unable to stop interface,\n already stopped"));
     return;
+  }
 	  
   int ret = system(QString("%1 %2 down").arg(IFCONFIG).arg(this->name()).latin1());
-  if(ret != 0)
+  if(ret != 0){
+    emit (updateMessage("Stopping interface failed."));
     return;
+  }
 
-  status = true;
+  status = false;
   refresh();
+  emit (updateMessage("Stop successfull"));
 }
 
 /**
diff --git a/noncore/settings/networksettings/interfaces/interface.h b/noncore/settings/networksettings/interfaces/interface.h
index dc9c6d3..fc064fe 100644
--- a/noncore/settings/networksettings/interfaces/interface.h
+++ b/noncore/settings/networksettings/interfaces/interface.h
@@ -11,7 +11,8 @@ class Interface : public QObject{
 
 signals:
   void updateInterface(Interface *i);
-	
+  void updateMessage(const QString &message);
+  
 public:
   Interface(QObject * parent=0, const char * name= "unknown", bool status = false);
   virtual ~Interface(){};
diff --git a/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp b/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp
index 43483fb..39575c4 100644
--- a/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp
+++ b/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp
@@ -4,6 +4,8 @@
 #include <qpushbutton.h>
 #include <qlabel.h>
 #include <qgroupbox.h>
+#include <qmessagebox.h>
+
 #include <assert.h>
 
 /**
@@ -15,13 +17,13 @@ InterfaceInformationImp::InterfaceInformationImp(QWidget *parent, const char *na
   
   interface = i;
   connect(i, SIGNAL(updateInterface(Interface *)), this, SLOT(updateInterface(Interface *)));
+  connect(i, SIGNAL(updateMessage(const QString &)), this, SLOT(showMessage(const QString &)));
   updateInterface(interface);
   connect(startButton, SIGNAL(clicked()), interface, SLOT(start()));
   connect(stopButton, SIGNAL(clicked()), interface, SLOT(stop()));
   connect(restartButton, SIGNAL(clicked()), interface, SLOT(restart()));
   connect(refreshButton, SIGNAL(clicked()), interface, SLOT(refresh()));
   connect(advancedButton, SIGNAL(clicked()), this, SLOT(advanced()));
-  
 }
 
 /**
@@ -66,5 +68,14 @@ void InterfaceInformationImp::advanced(){
   a->show();
 }
 
+/**
+ * Messages from the interface if start/stop went as planned.
+ * Purly for user feedback.
+ * @param message the message to display.
+ */ 
+void InterfaceInformationImp::showMessage(const QString &message){
+  QMessageBox::information(this, "Message", message, QMessageBox::Ok);
+}
+
 // infoimp.cpp
 
diff --git a/noncore/settings/networksettings/interfaces/interfaceinformationimp.h b/noncore/settings/networksettings/interfaces/interfaceinformationimp.h
index 42213cc..65cdfe0 100644
--- a/noncore/settings/networksettings/interfaces/interfaceinformationimp.h
+++ b/noncore/settings/networksettings/interfaces/interfaceinformationimp.h
@@ -15,6 +15,7 @@ public:
 private slots:
   void advanced();
   void updateInterface(Interface *i);
+  void showMessage(const QString &message);
 
 private:
   Interface *interface;
diff --git a/noncore/settings/networksettings/interfaces/interfaces.pro b/noncore/settings/networksettings/interfaces/interfaces.pro
index 9a024f6..d6b43fb 100644
--- a/noncore/settings/networksettings/interfaces/interfaces.pro
+++ b/noncore/settings/networksettings/interfaces/interfaces.pro
@@ -1,7 +1,7 @@
 TEMPLATE        = lib
 CONFIG          += qt warn_on release
 #CONFIG		+= qt warn_on debug
-DESTDIR		= $(QTDIR)/lib$(PROJMAK)
+#DESTDIR		= $(QTDIR)/lib$(PROJMAK)
 HEADERS		= interface.h  interfaceinformationimp.h  interfaces.h  interfacesetupimp.h
 SOURCES		= interface.cpp interfaces.cpp interfaceinformationimp.cpp  interfacesetupimp.cpp
 INCLUDEPATH	+= $(OPIEDIR)/include ../
--
cgit v0.9.0.2