Security fix by trolltech

1 files changed, 214 insertions, 210 deletions

diff --git a/core/launcher/qcopbridge.cpp b/core/launcher/qcopbridge.cpp
index 2d084fc..85993ee 100644
--- a/core/launcher/qcopbridge.cpp
+++ b/core/launcher/qcopbridge.cpp
@@ -1,7 +1,7 @@
 /**********************************************************************
-** Copyright (C) 2000 Trolltech AS.  All rights reserved.
+** Copyright (C) 2000-2002 Trolltech AS.  All rights reserved.
 **
-** This file is part of Qtopia Environment.
+** This file is part of the Qtopia Environment.
 **
 ** This file may be distributed and/or modified under the terms of the
 ** GNU General Public License version 2 as published by the Free Software
@@ -21,8 +21,11 @@
 #include "qcopbridge.h"
 #include "transferserver.h"
 
+#ifdef QWS
 #include <qpe/qcopenvelope_qws.h>
+#endif
 #include <qpe/qpeapplication.h>
+#include <qpe/version.h>
 
 #include <qdir.h>
 #include <qfile.h>
@@ -31,13 +34,11 @@
 #include <qstringlist.h>
 #include <qfileinfo.h>
 #include <qregexp.h>
+#ifdef QWS
 #include <qcopchannel_qws.h>
+#endif
 
-// actually this is wrong, _XOPEN_SOURCE should get defined on the commandline
-// and it should have a proper value assigned. (Simon)
-#if !defined(_XOPEN_SOURCE)
 #define _XOPEN_SOURCE
-#endif
 #include <pwd.h>
 #include <sys/types.h>
 #include <unistd.h>
@@ -50,28 +51,32 @@
 
 const int block_size = 51200;
 
-QCopBridge::QCopBridge( Q_UINT16 port, QObject *parent,
+QCopBridge::QCopBridge( Q_UINT16 port, QObject *parent ,
         const char* name )
     : QServerSocket( port, 1, parent, name ),
       desktopChannel( 0 ),
       cardChannel( 0 )
 {
     if ( !ok() )
-  qWarning( "Failed to bind to port %d", port );
+	qWarning( "Failed to bind to port %d", port );
     else {
-  desktopChannel = new QCopChannel( "QPE/Desktop", this );
-  connect( desktopChannel, SIGNAL(received(const QCString &, const QByteArray &)),
-     this, SLOT(desktopMessage( const QCString &, const QByteArray &)) );
-  cardChannel = new QCopChannel( "QPE/Card", this );
-  connect( cardChannel, SIGNAL(received(const QCString &, const QByteArray &)),
-     this, SLOT(desktopMessage( const QCString &, const QByteArray &)) );
+#ifndef QT_NO_COP
+	desktopChannel = new QCopChannel( "QPE/Desktop", this );
+	connect( desktopChannel, SIGNAL(received(const QCString &, const QByteArray &)),
+		 this, SLOT(desktopMessage( const QCString &, const QByteArray &)) );
+	cardChannel = new QCopChannel( "QPE/Card", this );
+	connect( cardChannel, SIGNAL(received(const QCString &, const QByteArray &)),
+		 this, SLOT(desktopMessage( const QCString &, const QByteArray &)) );
+#endif
     }
     sendSync = FALSE;
 }
 
 QCopBridge::~QCopBridge()
 {
+#ifndef QT_NO_COP
     delete desktopChannel;
+#endif
 }
 
 void QCopBridge::newConnection( int socket )
@@ -79,11 +84,13 @@ void QCopBridge::newConnection( int socket )
     QCopBridgePI *pi = new QCopBridgePI( socket, this );
     openConnections.append( pi );
     connect ( pi, SIGNAL( connectionClosed( QCopBridgePI *) ), this, SLOT( connectionClosed( QCopBridgePI *) ) );
+#ifndef QT_NO_COP
     QCopEnvelope( "QPE/System", "setScreenSaverMode(int)" ) << QPEApplication::DisableSuspend;
-    
+#endif
+
     if ( sendSync ) {
-  pi ->startSync();
-  sendSync = FALSE;
+	pi ->startSync();
+	sendSync = FALSE;
     }
 }
 
@@ -91,15 +98,17 @@ void QCopBridge::connectionClosed( QCopBridgePI *pi )
 {
     openConnections.remove( pi );
     if ( openConnections.count() == 0 ) {
-  QCopEnvelope( "QPE/System", "setScreenSaverMode(int)" ) << QPEApplication::Enable;
+#ifndef QT_NO_COP
+	QCopEnvelope( "QPE/System", "setScreenSaverMode(int)" ) << QPEApplication::Enable;
+#endif
     }
-}    
+}
 
 void QCopBridge::closeOpenConnections()
 {
     QCopBridgePI *pi;
     for ( pi = openConnections.first(); pi != 0; pi = openConnections.next() )
-  pi->close();
+	pi->close();
 }
 
 
@@ -109,14 +118,14 @@ void QCopBridge::desktopMessage( const QCString &command, const QByteArray &args
 
     int paren = command.find( "(" );
     if ( paren <= 0 ) {
-  qDebug("DesktopMessage: bad qcop syntax");
-  return;
+	qDebug("DesktopMessage: bad qcop syntax");
+	return;
     }
 
     QString params = command.mid( paren + 1 );
     if ( params[params.length()-1] != ')' ) {
-  qDebug("DesktopMessage: bad qcop syntax");
-  return;
+	qDebug("DesktopMessage: bad qcop syntax");
+	return;
     }
 
     params.truncate( params.length()-1 );
@@ -124,45 +133,63 @@ void QCopBridge::desktopMessage( const QCString &command, const QByteArray &args
     QStringList paramList = QStringList::split( ",", params );
     QString data;
     if ( paramList.count() ) {
-  QDataStream stream( args, IO_ReadOnly );
-  for ( QStringList::Iterator it = paramList.begin(); it != paramList.end(); ++it ) {
-      QString str;
-      if ( *it == "QString" ) {
-    stream >> str;
-      } else if ( *it == "QCString" ) {
-    QCString cstr;
-    stream >> cstr;
-    str = QString::fromLocal8Bit( cstr );
-      } else if ( *it == "int" ) {
-    int i;
-    stream >> i;
-    str = QString::number( i );
-      } else if ( *it == "bool" ) {
-    int i;
-    stream >> i;
-    str = QString::number( i );
-      } else {
-    qDebug(" cannot route the argument type %s through the qcop bridge", (*it).latin1() );
-    return;
-      }
-      str.replace( QRegExp("&"), "&amp;" );
-      str.replace( QRegExp(" "), "&0x20;" );
-      str.replace( QRegExp("\n"), "&0x0d;" );
-      str.replace( QRegExp("\r"), "&0x0a;" );
-      data += " " + str;
-  }
+	QDataStream stream( args, IO_ReadOnly );
+	for ( QStringList::Iterator it = paramList.begin(); it != paramList.end(); ++it ) {
+	    QString str;
+	    if ( *it == "QString" ) {
+		stream >> str;
+	    } else if ( *it == "QCString" ) {
+		QCString cstr;
+		stream >> cstr;
+		str = QString::fromLocal8Bit( cstr );
+	    } else if ( *it == "int" ) {
+		int i;
+		stream >> i;
+		str = QString::number( i );
+	    } else if ( *it == "bool" ) {
+		int i;
+		stream >> i;
+		str = QString::number( i );
+	    } else {
+		qDebug(" cannot route the argument type %s throught the qcop bridge", (*it).latin1() );
+		return;
+	    }
+	    QString estr;
+	    for (int i=0; i<(int)str.length(); i++) {
+		QChar ch = str[i];
+		if ( ch.row() )
+		    goto quick;
+		switch (ch.cell()) {
+		    case '&':
+			estr.append( "&amp;" );
+			break;
+		    case ' ':
+			estr.append( "&0x20;" );
+			break;
+		    case '\n':
+			estr.append( "&0x0d;" );
+			break;
+		    case '\r':
+			estr.append( "&0x0a;" );
+			break;
+		    default: quick:
+			estr.append(ch);
+		}
+	    }
+	    data += " " + estr;
+	}
     }
     QString sendCommand = QString(command.data()) + data;
     // send the command to all open connections
     if ( command == "startSync()" ) {
-  // we need to buffer it a bit
-  sendSync = TRUE;
-  startTimer( 20000 );
-    }  
-    
+	// we need to buffer it a bit
+	sendSync = TRUE;
+	startTimer( 20000 );
+    }
+
     QCopBridgePI *pi;
     for ( pi = openConnections.first(); pi != 0; pi = openConnections.next() ) {
-  pi->sendDesktopMessage( sendCommand );
+	pi->sendDesktopMessage( sendCommand );
     }
 }
 
@@ -173,8 +200,8 @@ void QCopBridge::timerEvent( QTimerEvent * )
 }
 
 
-QCopBridgePI::QCopBridgePI( int socket, QObject *parent, const char* name )
-    : QSocket( parent, name ) 
+QCopBridgePI::QCopBridgePI( int socket, QObject *parent , const char* name )
+    : QSocket( parent, name )
 {
     setSocket( socket );
 
@@ -182,23 +209,28 @@ QCopBridgePI::QCopBridgePI( int socket, QObject *parent, const char* name )
     peeraddress = peerAddress();
 
 #ifndef INSECURE
-    if ( !accessAuthorized(peeraddress) ) {
-  state = Forbidden;
-  startTimer( 0 );
-    } else 
-#endif  
+    if ( !SyncAuthentication::isAuthorized(peeraddress) ) {
+	state = Forbidden;
+	startTimer( 0 );
+    } else
+#endif	
     {
-  state = Connected;
-  sendSync = FALSE;
-  connect( this, SIGNAL( readyRead() ), SLOT( read() ) );
-  connect( this, SIGNAL( connectionClosed() ), SLOT( connectionClosed() ) );
-
-  send( "220 Qtopia QCop bridge ready!" );
-  state = Wait_USER;
-
-  // idle timer to close connections when not used anymore
-  startTimer( 60000 );
-  connected = TRUE;
+	state = Connected;
+	sendSync = FALSE;
+	connect( this, SIGNAL( readyRead() ), SLOT( read() ) );
+	connect( this, SIGNAL( connectionClosed() ), SLOT( connectionClosed() ) );
+
+	QString intro="220 Qtopia ";
+	intro += QPE_VERSION; intro += ";";
+	intro += "challenge="; intro += SyncAuthentication::serverId(); intro += ";";
+	intro += "loginname="; intro += SyncAuthentication::loginName(); intro += ";";
+	intro += "displayname="; intro += SyncAuthentication::ownerName(); intro += ";";
+	send( intro );
+	state = Wait_USER;
+
+	// idle timer to close connections when not used anymore
+	startTimer( 60000 );
+	connected = TRUE;
     }
 }
 
@@ -232,38 +264,7 @@ void QCopBridgePI::send( const QString& msg )
 void QCopBridgePI::read()
 {
     while ( canReadLine() )
-  process( readLine().stripWhiteSpace() );
-}
-
-bool QCopBridgePI::checkUser( const QString& user )
-{
-    if ( user.isEmpty() ) return FALSE;
-
-    struct passwd *pw;
-    pw = getpwuid( geteuid() );
-    QString euser = QString::fromLocal8Bit( pw->pw_name );
-    return user == euser;
-}
-
-bool QCopBridgePI::checkPassword( const QString& password )
-{
-    // ### HACK for testing on local host
-    return true;
-
-    /*
-    struct passwd *pw = 0;
-    struct spwd *spw = 0;
-
-    pw = getpwuid( geteuid() );
-    spw = getspnam( pw->pw_name );
-
-    QString cpwd = QString::fromLocal8Bit( pw->pw_passwd );
-    if ( cpwd == "x" && spw )
-  cpwd = QString::fromLocal8Bit( spw->sp_pwdp );
-
-    QString cpassword = QString::fromLocal8Bit( crypt( password.local8Bit(), cpwd.local8Bit() ) );
-    return cpwd == cpassword;
-*/
+	process( readLine().stripWhiteSpace() );
 }
 
 void QCopBridgePI::process( const QString& message )
@@ -280,133 +281,136 @@ void QCopBridgePI::process( const QString& message )
     // argument token
     QString arg;
     if ( msg.count() >= 2 )
-  arg = msg[1];
-    
+	arg = msg[1];
+
     // we always respond to QUIT, regardless of state
     if ( cmd == "QUIT" ) {
-  send( "211 Have a nice day!" );
-  delete this;
-  return;
+	send( "211 Have a nice day!" );
+	delete this;
+	return;
     }
 
     // connected to client
     if ( Connected == state )
-  return;
+	return;
 
     // waiting for user name
     if ( Wait_USER == state ) {
 
-  if ( cmd != "USER" || msg.count() < 2 || !checkUser( arg ) ) {
-      send( "530 Please login with USER and PASS" );
-      return;
-  }
-  send( "331 User name ok, need password" );
-  state = Wait_PASS;
-  return;
+	if ( cmd != "USER" || msg.count() < 2 || !SyncAuthentication::checkUser( arg ) ) {
+	    send( "530 Please login with USER and PASS" );
+	    return;
+	}
+	send( "331 User name ok, need password" );
+	state = Wait_PASS;
+	return;
     }
 
     // waiting for password
     if ( Wait_PASS == state ) {
 
-  if ( cmd != "PASS" || !checkPassword( arg ) ) {
-  //if ( cmd != "PASS" || msg.count() < 2 || !checkPassword( arg ) ) {
-      send( "530 Please login with USER and PASS" );
-      return;
-  }
-  send( "230 User logged in, proceed" );
-  state = Ready;
-  if ( sendSync ) {
-      sendDesktopMessage( "startSync()" );
-      sendSync = FALSE;
-  }
-  return;
+	if ( cmd != "PASS" || !SyncAuthentication::checkPassword( arg ) ) {
+	    send( "530 Please login with USER and PASS" );
+	    return;
+	}
+	send( "230 User logged in, proceed" );
+	state = Ready;
+	if ( sendSync ) {
+	    sendDesktopMessage( "startSync()" );
+	    sendSync = FALSE;
+	}
+	return;
     }
 
     // noop (NOOP)
     else if ( cmd == "NOOP" ) {
-  connected = TRUE;
-  send( "200 Command okay" );
+	connected = TRUE;
+	send( "200 Command okay" );
     }
-    
+
     // call (CALL)
     else if ( cmd == "CALL" ) {
 
-  // example: call QPE/System execute(QString) addressbook
-
-  if ( msg.count() < 3 ) {
-      send( "500 Syntax error, command unrecognized" );
-  }
-  else {
-
-      QString channel = msg[1];
-      QString command = msg[2];
-
-      command.stripWhiteSpace();
-
-      int paren = command.find( "(" );
-      if ( paren <= 0 ) {
-    send( "500 Syntax error, command unrecognized" );
-    return;
-      }
-
-      QString params = command.mid( paren + 1 );
-      if ( params[params.length()-1] != ')' ) {
-    send( "500 Syntax error, command unrecognized" );
-    return;
-      }
-
-      params.truncate( params.length()-1 );
-      QByteArray buffer;
-      QDataStream ds( buffer, IO_WriteOnly );
-
-      int msgId = 3;
-
-      QStringList paramList = QStringList::split( ",", params );
-      if ( paramList.count() > msg.count() - 3 ) {
-    send( "500 Syntax error, command unrecognized" );
-    return;
-      }
-
-      for ( QStringList::Iterator it = paramList.begin(); it != paramList.end(); ++it ) {
-
-    QString arg = msg[msgId];
-    arg.replace( QRegExp("&0x20;"), " " );
-    arg.replace( QRegExp("&amp;"), "&" );
-    arg.replace( QRegExp("&0x0d;"), "\n" );
-    arg.replace( QRegExp("&0x0a;"), "\r" );
-    if ( *it == "QString" )
-        ds << arg;
-    else if ( *it == "QCString" )
-        ds << arg.local8Bit();
-    else if ( *it == "int" )
-        ds << arg.toInt();
-    else if ( *it == "bool" )
-        ds << arg.toInt();
-    else {
-        send( "500 Syntax error, command unrecognized" );
-        return;
-    }
-    msgId++;
-      }
-
-      if ( !QCopChannel::isRegistered( channel.latin1() ) ) {
-    // send message back about it
-    QString answer = "599 ChannelNotRegistered " + channel;
-    send( answer );
-    return;
-      }
-      
-      if ( paramList.count() )
-    QCopChannel::send( channel.latin1(), command.latin1(), buffer );
-      else
-    QCopChannel::send( channel.latin1(), command.latin1() );
-
-      send( "200 Command okay" );
-  }
+	// example: call QPE/System execute(QString) addressbook
+
+	if ( msg.count() < 3 ) {
+	    send( "500 Syntax error, command unrecognized" );
+	}
+	else {
+
+	    QString channel = msg[1];
+	    QString command = msg[2];
+
+	    command.stripWhiteSpace();
+
+	    int paren = command.find( "(" );
+	    if ( paren <= 0 ) {
+		send( "500 Syntax error, command unrecognized" );
+		return;
+	    }
+
+	    QString params = command.mid( paren + 1 );
+	    if ( params[params.length()-1] != ')' ) {
+		send( "500 Syntax error, command unrecognized" );
+		return;
+	    }
+
+	    params.truncate( params.length()-1 );
+	    QByteArray buffer;
+	    QDataStream ds( buffer, IO_WriteOnly );
+
+	    int msgId = 3;
+
+	    QStringList paramList = QStringList::split( ",", params );
+	    if ( paramList.count() > msg.count() - 3 ) {
+		send( "500 Syntax error, command unrecognized" );
+		return;
+	    }
+
+	    for ( QStringList::Iterator it = paramList.begin(); it != paramList.end(); ++it ) {
+
+		QString arg = msg[msgId];
+		arg.replace( QRegExp("&0x20;"), " " );
+		arg.replace( QRegExp("&amp;"), "&" );
+		arg.replace( QRegExp("&0x0d;"), "\n" );
+		arg.replace( QRegExp("&0x0a;"), "\r" );
+		if ( *it == "QString" )
+		    ds << arg;
+		else if ( *it == "QCString" )
+		    ds << arg.local8Bit();
+		else if ( *it == "int" )
+		    ds << arg.toInt();
+		else if ( *it == "bool" )
+		    ds << arg.toInt();
+		else {
+		    send( "500 Syntax error, command unrecognized" );
+		    return;
+		}
+		msgId++;
+	    }
+
+#ifndef QT_NO_COP
+	    if ( !QCopChannel::isRegistered( channel.latin1() ) ) {
+		// send message back about it
+		QString answer = "599 ChannelNotRegistered " + channel;
+		send( answer );
+		return;
+	    }
+#endif
+	
+#ifndef QT_NO_COP
+	    if ( paramList.count() )
+		QCopChannel::send( channel.latin1(), command.latin1(), buffer );
+	    else
+		QCopChannel::send( channel.latin1(), command.latin1() );
+
+	    send( "200 Command okay" );
+#endif
+	}
     }
     // not implemented
     else
-  send( "502 Command not implemented" );
+	send( "502 Command not implemented" );
 }
 
 
@@ -414,7 +418,7 @@ void QCopBridgePI::process( const QString& message )
 void QCopBridgePI::timerEvent( QTimerEvent * )
 {
     if ( connected )
-  connected = FALSE;
+	connected = FALSE;
     else
-  connectionClosed();
+	connectionClosed();
 }