summaryrefslogtreecommitdiff
path: root/noncore
AgeCommit message (Collapse)AuthorFilesLines
2007-02-09This commit is based on the patch attached to Opie bug 1735:erik1-10/+25
http://opie-bugs.oszine.de/view.php?id=1735 It changes the opie-irc app to be able to support the additional user characters that the unrealircd irc daemon provides. Thanks goes to andrewy for reporting and providing a patch.
2007-02-08Removal of useless code based on a conditional that is never set to anythingerik1-49/+23
but false.
2007-02-08Each file in this commit has a problem where it is possible to dereferenceerik3-25/+53
a pointer without that pointer being valid. This commit fixes each instance of that.
2007-02-08This commit adds support for the HTC Universal bluetooth device toerik1-0/+4
bluezapplet. This commit is based on a patch submitted by GoXbox Live <goxboxlive at gmail dot com> to the opie-devel mailing list. Thanks GoXbox Live!
2007-02-07Update docs to match current status; add myself as maintainerpaule3-25/+53
2007-02-07Check lircd is configured before accepting button pressespaule1-1/+5
2007-02-07Start up gracefully when lircd is not properly configured yetpaule3-4/+20
2007-02-07Rename Add button to Learn; remove Edit button; move list updating to its ↵paule2-21/+34
own public slot and don't call it automatically (should be called from MainView when lircd is properly set up); correctly show learn dialog modal and update list when it closes; delete learn dialog when done
2007-02-07Implement learning process (requires patched irrecord with stdout buffering ↵paule2-32/+231
disabled)
2007-02-07Add functions for handling /etc/lircd.conf; do basic check of ↵paule2-0/+174
/etc/lircd.conf before attempting to commit in order to avoid timeouts
2007-02-06Start lircd on application start, and stop it on quitpaule3-19/+51
2007-02-05BUG: Lack of a << made opieplayer2 uncompilable.erik1-1/+1
FIX: It is put in now.
2007-02-05BUG: My change to a switch statement made opie-gutenbrowser uncompilable.erik1-11/+9
FIX: The code there is just strange. I tore out the switch statement and replaced it with a simple if block instead.
2007-01-31A few files that dereference pointers w/out checking that the pointer iserik3-28/+14
valid.
2007-01-31I expanded my audit to include any app I could get to compile in i386.erik8-235/+235
In that expansion a whole new crop of unchecked returns has sprung up. This commit fixes those weeds or should I say potential bugs.
2007-01-31Don't allow configuring buttons with no remote layout selectedpaule1-0/+8
2007-01-29Each file in this commit exhibits a problem where a variable is made inerik3-13/+6
some way but never used. This is a tricky problem with Qt since almost all UI forms are made but not used (like QLabel). But I am pretty confident that these changes are correct and do not have any aspect of a change to the UI. In most cases, there are just variables that are made and then copied over (like in iteration over lists or assignment of pointers based on conditionals).
2007-01-29Each file in this commit has an issue where the initial value of a variableerik12-48/+52
is assumed to be something but no initial value is given. This commit changes that by either assigning an initial value or removing the assumption on an initial value (usually the former).
2007-01-29Strictly removal of cruft (commented out old code).erik1-22/+0
2007-01-29Change buttons from QLabel to QPushButton, which enables entering the PIN ↵paule2-476/+366
using directional buttons and space/enter (which is all that is available on some PDAs if the screen is uncalibrated). In addition, you can now enter numbers using number keys if your device has them.
2007-01-28Change to not use new for message boxes; rename sendIR parameter to a more ↵paule2-12/+12
appropriate name
2007-01-28More fixes for remote selectionpaule2-0/+25
2007-01-28Don't allow creating remote layouts with a blank name; remove old commented ↵paule1-13/+4
out code
2007-01-28Remove unused source filespaule2-53/+0
2007-01-28Correctly select first remote upon loading configuration; pass current ↵paule1-14/+34
button action to button dialog; show error if user clicks on New without first typing a new name; show error if user clicks New with Remotes as a name
2007-01-28Correctly select first remote upon loading configuration; show a warning ↵paule1-4/+15
message if user presses a button that has not been configured
2007-01-28Correctly select first remote upon loading configurationpaule3-2/+6
2007-01-28Load in current button action on openingpaule2-17/+34
2007-01-28Refactored out all communication with LIRC into new LircHandler classpaule13-755/+344
2007-01-26Both files in this commit exhibit the wrong way to use temporary files.erik1-3/+24
For TEHistory.cpp, it uses tmpfile() which produces a file which has a name that can be guessed. For vmemo.cpp, it uses tmpname() which only creates a predictable string. Both uses have been switched to using mkstemp() wrapped around umask(). This produces a much less predictable file that also has guaranteed restrictive permissions. I went a little farther in vmemo because it calls out to the shell using system to 'mv' the new file. That is kinda wasteful so I switched it to use rename instead.
2007-01-26The Expand call does not check for null termination of the URL stringserik1-2/+4
that it is expanding. Since strlen() is used with the URLs after Expand is used, it is good idea to make sure that Expand terminates the strings. This commit changes that so that the URL strings are guaranteed to be terminated after expansion.
2007-01-26A couple of places where a string is overrun. This fixes both of them.erik2-4/+5
2007-01-26Each file in this commit exhibit an example of what prevent callserik2-2/+2
'reverse inull'. All that means is that a pointer gets dereferenced. Then a pointer gets checked for validity before being dereferenced again. This almost always points to shenanigans. For example, the konsole.cpp file has this konsoleInit() call which passes in a const char** shell variable. Since it is a double pointer the programmer who wrote the code made the mistake of mixing the checking of the pointer and the pointer that points to the pointer. This commit attempts to correct that. Of course there are other instances of the same thing. But they all boil down to a small mistake which might have produced strange side effects.
2007-01-26Both files in this commit exhibit use after free errors.erik2-4/+4
One of them was introduced in my memory leak fixing (whoops). I was freeing a structure of stock data before one last call to it. So switching the free to after that call fixed it. The kcheckers.cpp fix is one where the game board could be deleted and then a new one is not created because someone attempted to request a game board type that is not supported. This is fixed by using the default directive for one of the game board types in the switch statement. Which means it could default to Russian boards. Score one for the Russians!
2007-01-24There was quite a bit of deadwood in this file. I am removing it to makeerik1-65/+0
the file more readable (and smaller overall).
2007-01-24Each file in this commit has the issue where it is possible for code toerik6-38/+51
overrun static buffers. This could lead to serious problems. Granted it is almost impossible to do that. But it isn't totally impossible. So this commit makes it impossible to overrun.
2007-01-24Each file in this commit has the issue where a function can return aerik2-50/+49
negative result but the result is used in a context that can only be positive.
2007-01-24Each file in this commit has an instance where a pointer is checked aterik6-68/+77
one point in the code and then not checked in another point in the code. If it needed to be checked once, it needs to be checked the other time. If not the application could segfault.
2007-01-24Eac one the files in this commit had an instance where a code path iserik3-16/+2
never traversed because of conditionals operating on values that never change.
2007-01-24Every file in this commit has a memory leak of some kind or another. I thinkerik9-157/+246
all of them are minor and should not effect properly running code. But if I were you I would give libstocks and the stockticker plugin in Today a wide berth. That library is atrocious.
2007-01-23A couple more return values that need to be checked.erik1-2/+9
2007-01-22Each file in this commit had a problem where a function might returnerik3-5/+10
a null value for a pointer and that null value was not checked.
2007-01-22Every file in this commit makes a call to a function which returns a value.erik12-89/+101
Each file also didn't check the return value. This commit changes it so that every single non-checked call in these files is checked.
2007-01-19core/opie-login/loginwindowimpl.cpp has a fix to properly free stringserik1-0/+1
that were dup'ed. noncore/apps/opie-reader/Bkmks.cpp deletes a temporary pointer that was not being properly disposed of.
2007-01-19Every file in this commit has a change to check the return value of a call.erik3-6/+13
2007-01-19Every single file in this commit had a memory leak where a resource iserik7-16/+38
allocated in the constructor but not de-allocated in the destructor. This commit fixes that.
2007-01-19BUG: There are only 4095 items in the buffer that is zero'd out using 4096.erik1-1/+1
FIX: Fix the number used in memset.
2007-01-14When selecting a time zone, warn the user if the time zone file in ↵paule1-26/+35
/usr/share/zoneinfo for the selected time zone is missing
2007-01-14Add setting to show date/time settings on every restart (useful on devices ↵paule2-3/+16
where the date/time slips or is reset when the device is reset)
2007-01-13Actually read the doctab enable/disable setting.paule1-0/+7
Partially fixes bug #1618.