rec changes

11 files changed, 108 insertions, 99 deletions

diff --git a/korganizer/calendarview.cpp b/korganizer/calendarview.cpp
index a76f2ed..a9d42f0 100644
--- a/korganizer/calendarview.cpp
+++ b/korganizer/calendarview.cpp
@@ -3759,7 +3759,7 @@ void CalendarView::deleteEvent(Event *anEvent)
         return;
     }
 
-    if (anEvent->recurrence()->doesRecur()) {
+    if (anEvent->doesRecur()) {
         QDate itemDate = mViewManager->currentSelectionDate();
         int km;
         if (!itemDate.isValid()) {
diff --git a/korganizer/koagenda.cpp b/korganizer/koagenda.cpp
index 0dd5ef5..c738f7e 100644
--- a/korganizer/koagenda.cpp
+++ b/korganizer/koagenda.cpp
@@ -579,7 +579,7 @@ bool KOAgenda::eventFilter_mouse(QObject *object, QMouseEvent *me)
                     slotClearSelection();
                     selectItem(mActionItem);
                     Incidence *incidence = mActionItem->incidence();
-                    if ( incidence->isReadOnly() /*|| incidence->recurrence()->doesRecur() */) {
+                    if ( incidence->isReadOnly() /*|| incidence->doesRecur() */) {
                         mActionItem = 0;
                     } else {
                         startItemAction(viewportPos);
@@ -999,7 +999,7 @@ void KOAgenda::endItemAction()
         if ( !placeItem ) {
             placeItem = mActionItem;      
         }
-        if ( placeItem->incidence()->recurrence()->doesRecur() ) {
+        if ( placeItem->incidence()->doesRecur() ) {
             Incidence* oldInc =  placeItem->incidence();
             placeItem->recreateIncidence();
             emit addToCalSignal(placeItem->incidence(), oldInc );
diff --git a/korganizer/koagendaitem.cpp b/korganizer/koagendaitem.cpp
index 303a92a..49ad9b8 100644
--- a/korganizer/koagendaitem.cpp
+++ b/korganizer/koagendaitem.cpp
@@ -234,7 +234,7 @@ bool KOAgendaItem::updateIcons(QPainter * p, bool horLayout)
         else
             ++yOff;
     }
-    if (mIncidence->recurrence()->doesRecur()) {
+    if (mIncidence->doesRecur()) {
         p->fillRect ( xOff*( 1 +AGENDA_ICON_SIZE )+x, yOff*( 1 +AGENDA_ICON_SIZE)+y, AGENDA_ICON_SIZE, AGENDA_ICON_SIZE, blue );
         if ( horLayout )
             ++xOff;
diff --git a/korganizer/koagendaview.cpp b/korganizer/koagendaview.cpp
index a01323a..04f30bb 100644
--- a/korganizer/koagendaview.cpp
+++ b/korganizer/koagendaview.cpp
@@ -1201,7 +1201,7 @@ void KOAgendaView::fillAgenda()
             //      kdDebug() << "  beginX: " << beginX << "  endX: " << endX << endl;
 
             if (event->doesFloat()) {
-                if (event->recurrence()->doesRecur()) {
+                if (event->doesRecur()) {
                     if (event->isMultiDay() ) {
                         endX = endX - beginX;// endX is now number of days
                         if ( event->recursOn( currentDate ) ) {
diff --git a/korganizer/kodaymatrix.cpp b/korganizer/kodaymatrix.cpp
index ec1154a..057df0d 100644
--- a/korganizer/kodaymatrix.cpp
+++ b/korganizer/kodaymatrix.cpp
@@ -453,7 +453,7 @@ void KODayMatrix::updateViewTimed()
     QDate mStartDate = days[0];
     QDate endDate =  mStartDate.addDays( timeSpan );
     for( event = events.first(); event; event = events.next() ) { // for event
-        ushort recurType = event->recurrence()->doesRecur();
+        ushort recurType = event->doesRecur();
         if ((recurType == Recurrence::rDaily && !KOPrefs::instance()->mDailyRecur) ||
             (recurType == Recurrence::rWeekly && !KOPrefs::instance()->mWeeklyRecur)) {
             continue;
diff --git a/korganizer/koeditorrecurrence.cpp b/korganizer/koeditorrecurrence.cpp
index de4e4f7..89504db 100644
--- a/korganizer/koeditorrecurrence.cpp
+++ b/korganizer/koeditorrecurrence.cpp
@@ -897,100 +897,102 @@ void KOEditorRecurrence::readEvent(Incidence *event)
   int month = 0;
   setDateTimes( event->dtStart(), dtEnd );
 
-  Recurrence *r = event->recurrence();
-  int f = r->frequency();
+ 
 
-  int recurs = r->doesRecur();
+  int recurs = event->doesRecur();
 
   mEnabledCheck->setChecked( recurs );
   setEnabled( recurs );
 
   int recurrenceType = RecurrenceChooser::Weekly;
-
-  switch ( recurs ) {
-    case Recurrence::rNone:
-        setDefaults( event->dtStart(), dtEnd );
-      break;
-    case Recurrence::rDaily:
-      recurrenceType = RecurrenceChooser::Daily;
-      mDaily->setFrequency( f );
-      break;
-    case Recurrence::rWeekly:
-      recurrenceType = RecurrenceChooser::Weekly;
-      mWeekly->setFrequency( f );
-      mWeekly->setDays( r->days() );
-      break;
-    case Recurrence::rMonthlyPos:
-      // we only handle one possibility in the list right now,
-      // so I have hardcoded calls with first().  If we make the GUI
-      // more extended, this can be changed.
-      recurrenceType = RecurrenceChooser::Monthly;
-
-      rmp = r->monthPositions();
-      if ( rmp.first()->negative )
-        count = 5 - rmp.first()->rPos - 1;
-      else
-        count = rmp.first()->rPos - 1;
-      day = 0;
-      while ( !rmp.first()->rDays.testBit( day ) ) ++day;
-      mMonthly->setByPos( count, day );
-
-      mMonthly->setFrequency( f );
-
-      break;
-    case Recurrence::rMonthlyDay:
-      recurrenceType = RecurrenceChooser::Monthly;
-
-      rmd = r->monthDays();
-      day = *rmd.first() - 1;
-      mMonthly->setByDay( day );
-
-      mMonthly->setFrequency( f );
-
-      break;
-    case Recurrence::rYearlyMonth:
-        {
-        recurrenceType = RecurrenceChooser::Yearly;
-        //qDebug("Recurrence::rYearlyMonth: ");
-            day = event->dtStart().date().day(); 
-            rmd = r->yearNums();
-            if ( rmd.count() > 0 )
-                month = *rmd.first();
-            else
-                month = event->dtStart().date().month() ;
-            mYearly->setByMonth( month, day );
+  if ( recurs ) {
+      Recurrence *r = event->recurrence();
+      int f = r->frequency();
+      switch ( recurs ) {
+      case Recurrence::rNone:
+          setDefaults( event->dtStart(), dtEnd );
+          break;
+      case Recurrence::rDaily:
+          recurrenceType = RecurrenceChooser::Daily;
+          mDaily->setFrequency( f );
+          break;
+      case Recurrence::rWeekly:
+          recurrenceType = RecurrenceChooser::Weekly;
+          mWeekly->setFrequency( f );
+          mWeekly->setDays( r->days() );
+          break;
+      case Recurrence::rMonthlyPos:
+          // we only handle one possibility in the list right now,
+          // so I have hardcoded calls with first().  If we make the GUI
+          // more extended, this can be changed.
+          recurrenceType = RecurrenceChooser::Monthly;
+
+          rmp = r->monthPositions();
+          if ( rmp.first()->negative )
+              count = 5 - rmp.first()->rPos - 1;
+          else
+              count = rmp.first()->rPos - 1;
+          day = 0;
+          while ( !rmp.first()->rDays.testBit( day ) ) ++day;
+          mMonthly->setByPos( count, day );
+
+          mMonthly->setFrequency( f );
+
+          break;
+      case Recurrence::rMonthlyDay:
+          recurrenceType = RecurrenceChooser::Monthly;
+
+          rmd = r->monthDays();
+          day = *rmd.first() - 1;
+          mMonthly->setByDay( day );
+
+          mMonthly->setFrequency( f );
+
+          break;
+      case Recurrence::rYearlyMonth:
+          {
+              recurrenceType = RecurrenceChooser::Yearly;
+              //qDebug("Recurrence::rYearlyMonth: ");
+              day = event->dtStart().date().day(); 
+              rmd = r->yearNums();
+              if ( rmd.count() > 0 )
+                  month = *rmd.first();
+              else
+                  month = event->dtStart().date().month() ;
+              mYearly->setByMonth( month, day );
 #if 0
-            //qDebug("2day = %d ",day );
-            QPtrList<Recurrence::rMonthPos> monthlist = r->yearMonthPositions();
-            int month;
-            if ( !monthlist.isEmpty() ) {
-                month =  monthlist.first()->rPos ;
-            } else {
-                month = event->dtStart().date().month() ;
-            }
-            mYearly->setByMonth( day, month );
+              //qDebug("2day = %d ",day );
+              QPtrList<Recurrence::rMonthPos> monthlist = r->yearMonthPositions();
+              int month;
+              if ( !monthlist.isEmpty() ) {
+                  month =  monthlist.first()->rPos ;
+              } else {
+                  month = event->dtStart().date().month() ;
+              }
+              mYearly->setByMonth( day, month );
 #endif
-            mYearly->setFrequency( f );
-        }
+              mYearly->setFrequency( f );
+          }
 
-      break;
-    case Recurrence::rYearlyDay:
-        //qDebug("Recurrence::rYearlyDay: ");
-        recurrenceType = RecurrenceChooser::Yearly;
-        mYearly->setByDay( event->dtStart().date().dayOfYear() );
-        mYearly->setFrequency( f );
-        break;
-    default:
-        setDefaults( event->dtStart(), dtEnd );
-      break;
+          break;
+      case Recurrence::rYearlyDay:
+          //qDebug("Recurrence::rYearlyDay: ");
+          recurrenceType = RecurrenceChooser::Yearly;
+          mYearly->setByDay( event->dtStart().date().dayOfYear() );
+          mYearly->setFrequency( f );
+          break;
+      default:
+          setDefaults( event->dtStart(), dtEnd );
+          break;
+      }
   }
-
   mRecurrenceChooser->setType( recurrenceType );
   showCurrentRule( recurrenceType );
 
   mRecurrenceRange->setDateTimes( event->dtStart() );
 
-  if ( r->doesRecur() ) {
+  if ( event->doesRecur() ) {
+      Recurrence *r = event->recurrence();
     mRecurrenceRange->setDuration( r->duration() );
     if ( r->duration() == 0 ) 
         {
@@ -1007,12 +1009,16 @@ void KOEditorRecurrence::readEvent(Incidence *event)
 
 void KOEditorRecurrence::writeEvent( Incidence *event )
 {
-  Recurrence *r = event->recurrence();
+  
 
-  // clear out any old settings;
-  r->unsetRecurs();
+  if ( !mEnabledCheck->isChecked() ) {
+      if ( event->doesRecur() )
+          event->recurrence()->unsetRecurs();
+  } else {
+      Recurrence *r = event->recurrence();
 
-  if ( mEnabledCheck->isChecked() ) {
+      // clear out any old settings;
+      r->unsetRecurs();
     int duration = mRecurrenceRange->duration();
     QDate endDate;
     if ( duration == 0 ) endDate = mRecurrenceRange->endDate();
diff --git a/korganizer/koeventviewer.cpp b/korganizer/koeventviewer.cpp
index a690ab1..db695f5 100644
--- a/korganizer/koeventviewer.cpp
+++ b/korganizer/koeventviewer.cpp
@@ -347,9 +347,9 @@ void KOEventViewer::appendEvent(Event *event, int mode )
         addTag("p","<b>"+i18n("Location: ")+"</b>"+  deTag(event->location() ) );
         mMailSubject += i18n(" at ") + event->location();
     }
-    if (event->recurrence()->doesRecur()) {
+    if (event->doesRecur()) {
 
-        QString recurText = event->recurrence()->recurrenceText();
+        QString recurText = event->recurrenceText();
         addTag("p","<em>" + i18n("This is a %1 recurring event.").arg(recurText ) + "</em>");
         bool ok;
         QDate start = QDate::currentDate();
@@ -481,7 +481,7 @@ void KOEventViewer::appendTodo(Todo *event, int mode )
    
    
 
-    if (event->recurrence()->doesRecur()) {
+    if (event->doesRecur()) {
 
         QString recurText = event->recurrence()->recurrenceText();
         addTag("p","<em>" + i18n("This is a %1 recurring todo.").arg(recurText ) + "</em>");
diff --git a/korganizer/kolistview.cpp b/korganizer/kolistview.cpp
index d25f671..e7a5e0e 100644
--- a/korganizer/kolistview.cpp
+++ b/korganizer/kolistview.cpp
@@ -133,7 +133,7 @@ bool ListItemVisitor::visit(Event *e)
     } else {
         mItem->setText(5, i18n("No"));
     }
-    mItem->setText(6, e->recurrence()->recurrenceText());
+    mItem->setText(6, e->recurrenceText());
     if( ! e->doesRecur() )
         mItem->setSortKey( 6, "-" );
     mItem->setText(7,"---");
@@ -184,7 +184,7 @@ bool ListItemVisitor::visit(Todo *t)
     } else {
         mItem->setText(5, i18n("No"));
     }
-    mItem->setText(6, t->recurrence()->recurrenceText());
+    mItem->setText(6, t->recurrenceText());
     if( ! t->doesRecur() )
         mItem->setSortKey( 6, "-" );
     if (t->hasDueDate()) {
diff --git a/korganizer/komonthview.cpp b/korganizer/komonthview.cpp
index 498d9b0..eea9a4d 100644
--- a/korganizer/komonthview.cpp
+++ b/korganizer/komonthview.cpp
@@ -787,7 +787,7 @@ int MonthViewCell::insertEvent(Event *event)
         }
         pal.setColor(QColorGroup::Highlight, KOPrefs::instance()->mHighlightColor);
         item->setPalette( pal );
-        item->setRecur( event->recurrence()->doesRecur() );
+        item->setRecur( event->doesRecur() );
         item->setAlarm( event->isAlarmEnabled() && multiday < 2 && event->alarmEnabled() );
         item->setMoreInfo( event->description().length() > 0  );
 #ifdef DESKTOP_VERSION
@@ -878,7 +878,7 @@ void MonthViewCell::insertTodo(Todo *todo)
         }
         pal.setColor(QColorGroup::Highlight, KOPrefs::instance()->mHighlightColor);
         item->setPalette( pal );
-        item->setRecur( todo->recurrence()->doesRecur() );
+        item->setRecur( todo->doesRecur() );
         item->setAlarm( todo->isAlarmEnabled() && todo->alarmEnabled() );
         item->setMoreInfo( todo->description().length() > 0  );
         insertItem( item , count());
@@ -1105,6 +1105,8 @@ void MonthViewCell::contextMenu( QListBoxItem *item )
         mMonthView->showContextMenu( 0 );
         return;
     }
+    //selection( item );
+    //qApp->processEvents();
     MonthViewItem *eventItem = static_cast<MonthViewItem *>( item );
     Incidence *incidence = eventItem->incidence();
     if ( incidence ) mMonthView->showContextMenu( incidence );
diff --git a/korganizer/kotodoeditor.cpp b/korganizer/kotodoeditor.cpp
index 100a81b..682f83b 100644
--- a/korganizer/kotodoeditor.cpp
+++ b/korganizer/kotodoeditor.cpp
@@ -377,7 +377,8 @@ void KOTodoEditor::writeTodo(Todo *event)
         }
     } else {
         event->setHasRecurrenceID( false );
-        event->recurrence()->unsetRecurs();
+        if ( event->doesRecur() )
+            event->recurrence()->unsetRecurs();
     }
 }
 
diff --git a/korganizer/kowhatsnextview.cpp b/korganizer/kowhatsnextview.cpp
index fafcb58..f88403c 100644
--- a/korganizer/kowhatsnextview.cpp
+++ b/korganizer/kowhatsnextview.cpp
@@ -507,7 +507,7 @@ bool KOWhatsNextView::appendEvent(Incidence *ev, bool reply, bool notRed, bool a
             if (!ev->doesFloat()) {
                 Event *event = static_cast<Event *>(ev);
                 QDateTime st,end;
-                if ( event->recurrence()->doesRecur() ) {
+                if ( event->doesRecur() ) {
                     QDate  recDate= mEventDate;
                     int days =  event->dtStart().date().daysTo (event->dtEnd().date()  );
                     while ( ! event->recursOn(  recDate ) ) {
@@ -622,7 +622,7 @@ bool KOWhatsNextView::appendEvent(Incidence *ev, bool reply, bool notRed, bool a
         tempText += "i";
         needClose =true;
     }
-    if ( ev->recurrence()->doesRecur() ) {
+    if ( ev->doesRecur() ) {
         if ( !needClose)
             tempText +="[";
         tempText += "r";