author | zecke <zecke> | 2004-09-12 18:55:56 (UTC) |
---|---|---|
committer | zecke <zecke> | 2004-09-12 18:55:56 (UTC) |
commit | 46a2a6d2f0046b6971cae371453705f6177fc93e (patch) (side-by-side diff) | |
tree | efb29d94d733716631f65820249e81691ff55761 /core/obex | |
parent | 36a4f75e1f4e5a3858749779ea26a3fe3154d1f0 (diff) | |
download | opie-46a2a6d2f0046b6971cae371453705f6177fc93e.zip opie-46a2a6d2f0046b6971cae371453705f6177fc93e.tar.gz opie-46a2a6d2f0046b6971cae371453705f6177fc93e.tar.bz2 |
-Kill all owarn statements as they're not needed/useful anymore
-Kill all hardcoding to latin1 and use the system encoding/decoding
-rw-r--r-- | core/obex/obex.cc | 28 | ||||
-rw-r--r-- | core/obex/obexsend.cpp | 7 | ||||
-rw-r--r-- | core/obex/receiver.cpp | 18 |
3 files changed, 9 insertions, 44 deletions
diff --git a/core/obex/obex.cc b/core/obex/obex.cc index 7c40b90..5dfcfb5 100644 --- a/core/obex/obex.cc +++ b/core/obex/obex.cc @@ -34,7 +34,6 @@ Obex::~Obex() { void Obex::receive() { m_receive = true; m_outp = QString::null; - owarn << "Receive" << oendl; m_rec = new OProcess(); *m_rec << "irobex_palm3"; // connect to the necessary slots @@ -45,28 +44,22 @@ void Obex::receive() { this, SLOT(slotStdOut(Opie::Core::OProcess*, char*, int) ) ); if(!m_rec->start(OProcess::NotifyOnExit, OProcess::AllOutput) ) { - owarn << "could not start :(" oendl; emit done( false ); delete m_rec; m_rec = 0; } -// emit currentTry(m_count ); - } + void Obex::send( const QString& fileName) { // if currently receiving stop it send receive m_count = 0; m_file = fileName; - owarn << "send " << fileName.latin1() << oendl; if (m_rec != 0 ) { - owarn << "running" oendl; if (m_rec->isRunning() ) { emit error(-1 ); - owarn << "is running" << oendl; delete m_rec; m_rec = 0; }else{ - owarn << "is not running" << oendl; emit error( -1 ); // we did not delete yet but it's not running slotExited is pending return; } @@ -74,7 +67,6 @@ void Obex::send( const QString& fileName) { // if currently receiving stop it se sendNow(); } void Obex::sendNow(){ - owarn << "sendNow" << oendl; if ( m_count >= 25 ) { // could not send emit error(-1 ); emit sent(false); @@ -93,7 +85,6 @@ void Obex::sendNow(){ // now start it if (!m_send->start(/*OProcess::NotifyOnExit, OProcess::AllOutput*/ ) ) { - owarn << "could not send" << oendl; m_count = 25; emit error(-1 ); delete m_send; @@ -105,17 +96,16 @@ void Obex::sendNow(){ } void Obex::slotExited(OProcess* proc ){ - if (proc == m_rec ) { // receive process + if (proc == m_rec ) // receive process received(); - }else if ( proc == m_send ) { + else if ( proc == m_send ) sendEnd(); - } + } void Obex::slotStdOut(OProcess* proc, char* buf, int len){ if ( proc == m_rec ) { // only receive QByteArray ar( len ); memcpy( ar.data(), buf, len ); - owarn << "parsed: " << ar.data() << oendl; m_outp.append( ar ); } } @@ -124,7 +114,6 @@ void Obex::received() { if (m_rec->normalExit() ) { if ( m_rec->exitStatus() == 0 ) { // we got one QString filename = parseOut(); - owarn << "ACHTUNG " << filename.latin1() << oendl; emit receivedFile( filename ); } }else{ @@ -140,13 +129,11 @@ void Obex::sendEnd() { if ( m_send->exitStatus() == 0 ) { delete m_send; m_send=0; - owarn << "done" << oendl; emit sent(true); }else if (m_send->exitStatus() == 255 ) { // it failed maybe the other side wasn't ready // let's try it again delete m_send; m_send = 0; - owarn << "try sending again" << oendl; sendNow(); } }else { @@ -163,14 +150,10 @@ QString Obex::parseOut( ){ if ( (*it).startsWith("Wrote" ) ) { int pos = (*it).findRev('(' ); if ( pos > 0 ) { - owarn << pos << " " << (*it).mid(6 ).latin1() << oendl; - owarn << (*it).length() << " " << (*it).length()-pos << oendl; path = (*it).remove( pos, (*it).length() - pos ); - owarn << path.latin1() << oendl; path = path.mid(6 ); path = path.stripWhiteSpace(); - owarn << "path " << path.latin1() << oendl; } } } @@ -180,7 +163,6 @@ QString Obex::parseOut( ){ * when sent is done slotError is called we will start receive again */ void Obex::slotError() { - owarn << "slotError" << oendl; if ( m_receive ) receive(); }; @@ -193,10 +175,8 @@ void Obex::setReceiveEnabled( bool receive ) { void Obex::shutDownReceive() { if (m_rec != 0 ) { - owarn << "running" << oendl; if (m_rec->isRunning() ) { emit error(-1 ); - owarn << "is running" << oendl; delete m_rec; m_rec = 0; } diff --git a/core/obex/obexsend.cpp b/core/obex/obexsend.cpp index f3dd11c..675c5e4 100644 --- a/core/obex/obexsend.cpp +++ b/core/obex/obexsend.cpp @@ -105,7 +105,6 @@ void SendWidget::send( const QString& file, const QString& desc ) { } } void SendWidget::slotIrDaDevices( const QStringList& list) { - owarn << "slot it irda devices " << oendl; for (QStringList::ConstIterator it = list.begin(); it != list.end(); ++it ) { int id = m_devBox->addDevice( (*it), DeviceBox::IrDa, tr("Scheduling for beam.") ); m_irDa.insert( id, (*it) ); @@ -123,8 +122,7 @@ void SendWidget::slotBTDevices( const QMap<QString, QString>& str ) { } m_devBox->removeDevice( m_btDeSearch ); } -void SendWidget::slotSelectedDevice( int name, int dev ) { - owarn << "Start beam? " << name << " " << dev << "" << oendl; +void SendWidget::slotSelectedDevice( int name, int ) { if ( name == m_irDeSearch ) { for (QMap<int, QString>::Iterator it= m_irDa.begin(); it != m_irDa.end(); ++it ) m_devBox->removeDevice( it.key() ); @@ -133,7 +131,6 @@ void SendWidget::slotSelectedDevice( int name, int dev ) { } } void SendWidget::dispatchIrda( const QCString& str, const QByteArray& ar ) { - owarn << "dispatch irda " << str.data() << "" << oendl; if ( str == "devices(QStringList)" ) { QDataStream stream( ar, IO_ReadOnly ); QStringList list; @@ -148,7 +145,6 @@ void SendWidget::slotIrError( int ) { } void SendWidget::slotIrSent( bool b) { - owarn << "irda sent!!" << oendl; QString text = b ? tr("Sent") : tr("Failure"); m_devBox->setStatus( m_irDaIt.key(), text ); ++m_irDaIt; @@ -205,7 +201,6 @@ void DeviceBox::setStatus( int id, const QString& status ) { setText( allText() ); } void DeviceBox::setSource( const QString& str ) { - owarn << "SetSource:" << str.toInt() << "" << oendl; int id = str.toInt(); emit selectedDevice( id, m_dev[id].device() ); } diff --git a/core/obex/receiver.cpp b/core/obex/receiver.cpp index d4ae323..7d9a42a 100644 --- a/core/obex/receiver.cpp +++ b/core/obex/receiver.cpp @@ -76,17 +76,15 @@ void Receiver::tidyUp( QString& _file, const QString& ending) { if ( fd == -1 ) return; - (void)::strncat( foo, ending.latin1(), 4 ); - _file = QString::fromLatin1( foo ); + (void)::strncat( foo, QFile::encodeName(ending), 4 ); + _file = QString::fromLocal8Bit( foo ); QString cmd = QString("sed -e \"s/^\\(X-MICROSOFT-BODYINK\\)\\;/\\1:/;\" < %2 > %2 ").arg( Global::shellQuote(file)).arg( Global::shellQuote(_file) ); - owarn << "Executing: " << cmd << "" << oendl; - (void)::system( cmd.latin1() ); + (void)::system( QFile::encodeName(cmd) ); cmd = QString("rm %1").arg( Global::shellQuote(file) ); - (void)::system( cmd.latin1() ); + (void)::system( QFile::encodeName(cmd) ); } int Receiver::checkFile( QString& file ) { - owarn << "check file!! " << file << "" << oendl; int ret; QString ending; @@ -111,7 +109,6 @@ int Receiver::checkFile( QString& file ) { */ tidyUp( file, ending ); - owarn << "check it now " << ret << "" << oendl; return ret; } @@ -152,7 +149,6 @@ void OtherHandler::handle( const QString& file ) { m_file = file; m_na->setText(file); DocLnk lnk(file); - owarn << " " << lnk.type() << " " << lnk.icon() << "" << oendl; QString str = tr("<p>You received a file of type %1 (<img src=\"%2\"> )What do you want to do?").arg(lnk.type() ).arg(lnk.icon() ); m_view->setText( str ); @@ -195,14 +191,8 @@ QString OtherHandler::targetName( const QString& file ) { /* fast cpy */ void OtherHandler::copy(const QString& src, const QString& file) { - owarn << "src " << src << ", dest " << file << "" << oendl; FileManager *fm; if(!fm->copyFile(src,file)) { owarn << "Copy failed" << oendl; } - -// QString cmd = QString("mv %1 %2").arg( Global::shellQuote( src )). -// arg( Global::shellQuote( file ) ); -// ::system( cmd.latin1() ); - // done } |